<html>
<head><meta charset="utf-8"><title>VS Code requirement is too high · t-compiler/rust-analyzer · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/index.html">t-compiler/rust-analyzer</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html">VS Code requirement is too high</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="220570564"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220570564" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220570564">(Dec 21 2020 at 10:31)</a>:</h4>
<blockquote>
<p>Unable to install extension 'matklad.rust-analyzer' as it is not compatible with VS Code '1.51.1'.</p>
</blockquote>
<p>Why are we bumping the VS Code requirement so aggressively? NixOS is still on 1.51.1, so using rust-analyzer master is impossible there.</p>



<a name="220571080"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220571080" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220571080">(Dec 21 2020 at 10:39)</a>:</h4>
<p>CC <a href="https://github.com/rust-analyzer/rust-analyzer/pull/6779">https://github.com/rust-analyzer/rust-analyzer/pull/6779</a></p>



<a name="220571385"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220571385" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220571385">(Dec 21 2020 at 10:44)</a>:</h4>
<p>We used to support only the latest version, but now that's supposed to be the latest two versions</p>



<a name="220571482"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220571482" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220571482">(Dec 21 2020 at 10:45)</a>:</h4>
<p>Hm, good call on the latest two versions</p>



<a name="220571528"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220571528" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220571528">(Dec 21 2020 at 10:46)</a>:</h4>
<p>guess it makes sense to revert that on the reelase branch...</p>



<a name="220573386"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220573386" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220573386">(Dec 21 2020 at 11:13)</a>:</h4>
<p>Hm, thinking just a bit more about it, seems like "two releases" strategy is not tenable... cc <span class="user-mention" data-user-id="203366">@Jeremy Kolb</span> .</p>
<p>The problem is that the underlying LSP library we use uses "latest stable" policy. This is understandable -- they need to bind to the latest VS Code APIs to use new features.  <em>And</em> we need to use the latest library to have access to latest features as well. Sticking to an older release is not an option imo: supporting older vscodes is good, but enforcing older vscodes on everyone is not.</p>



<a name="220573444"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220573444" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220573444">(Dec 21 2020 at 11:14)</a>:</h4>
<p>I think the simplest thing we can do is reverting to the "latest stable" policy, + a provision that old extensions work with new server binary</p>



<a name="220573470"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220573470" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220573470">(Dec 21 2020 at 11:14)</a>:</h4>
<p>(which, sadly, isn't the case in today's release)</p>



<a name="220573594"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220573594" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220573594">(Dec 21 2020 at 11:16)</a>:</h4>
<p>Some alternatives are:</p>
<ul>
<li>prodding upstream (vscode-langauge-server-node) to support several versions of vscode in one library </li>
<li>divorcing extension update from server binary updates, by enabling "call github releases API" trick on stable as well.</li>
</ul>



<a name="220591841"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220591841" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220591841">(Dec 21 2020 at 15:00)</a>:</h4>
<p>I'm not sure how to solve the <code>vscode-languageclient</code> versioning. We could stick with the latest stable package but then we'd be missing out on things like semantic highlighting for 9 months so I'm not a big fan of that option.</p>



<a name="220592051"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220592051" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220592051">(Dec 21 2020 at 15:02)</a>:</h4>
<p>I think it may make sense to have some sort of extension/server compatibility matrix</p>



<a name="220592215"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220592215" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220592215">(Dec 21 2020 at 15:03)</a>:</h4>
<p>I think the "doesn't die on startup" would be good enough level of compat</p>



<a name="220592220"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220592220" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220592220">(Dec 21 2020 at 15:03)</a>:</h4>
<p>see <a href="https://github.com/gluon-lang/lsp-types/pull/193">https://github.com/gluon-lang/lsp-types/pull/193</a></p>



<a name="220592285"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220592285" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220592285">(Dec 21 2020 at 15:04)</a>:</h4>
<p>(and <a href="https://github.com/serde-rs/serde/issues/1908">https://github.com/serde-rs/serde/issues/1908</a>)</p>



<a name="220592392"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220592392" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Florian Diebold <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220592392">(Dec 21 2020 at 15:05)</a>:</h4>
<p>ah, that's probably <a href="https://github.com/rust-analyzer/rust-analyzer/issues/6979">rust-analyzer#6979</a> then as well...</p>



<a name="220592475"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220592475" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Florian Diebold <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220592475">(Dec 21 2020 at 15:05)</a>:</h4>
<p>... or at least related to that?</p>



<a name="220592890"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220592890" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220592890">(Dec 21 2020 at 15:09)</a>:</h4>
<p>:(</p>



<a name="220592895"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220592895" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220592895">(Dec 21 2020 at 15:09)</a>:</h4>
<p>:( :( :(</p>



<a name="220592969"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220592969" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220592969">(Dec 21 2020 at 15:10)</a>:</h4>
<p>that's me messing-up release</p>



<a name="220593011"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220593011" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220593011">(Dec 21 2020 at 15:10)</a>:</h4>
<p>I <em>think</em>...</p>



<a name="220593203"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220593203" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220593203">(Dec 21 2020 at 15:12)</a>:</h4>
<p>Hm, can anyone spot the bug in <a href="https://github.com/gluon-lang/lsp-types/pull/193/files">https://github.com/gluon-lang/lsp-types/pull/193/files</a> ?</p>



<a name="220593867"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220593867" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220593867">(Dec 21 2020 at 15:18)</a>:</h4>
<p>It looks right...</p>



<a name="220593997"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220593997" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220593997">(Dec 21 2020 at 15:19)</a>:</h4>
<p>OH</p>



<a name="220594222"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220594222" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220594222">(Dec 21 2020 at 15:21)</a>:</h4>
<p>The existing code is wrong. According to the spec it needs to be <code>groups_on_label</code>.</p>



<a name="220594423"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220594423" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220594423">(Dec 21 2020 at 15:23)</a>:</h4>
<p>That might be causing deserialize to fail</p>



<a name="220603238"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/VS%20Code%20requirement%20is%20too%20high/near/220603238" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/VS.20Code.20requirement.20is.20too.20high.html#220603238">(Dec 21 2020 at 16:40)</a>:</h4>
<p>Is <a href="https://github.com/rust-analyzer/rust-analyzer/issues/6414#issuecomment-749063940">https://github.com/rust-analyzer/rust-analyzer/issues/6414#issuecomment-749063940</a> the same problem?</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>